DOMRect normalizes NaN and negative zero to zero
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.3k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 4
Description
Description
The shared numeric conversion used by DOMRectReadOnly construction and mutable DOMRect setters defaults all falsy values to 0. Valid NaN is therefore replaced with zero and -0 loses its sign.
Expected behavior
Only omitted/nullish optional values should receive the zero default. Supplied numeric values should undergo normal Number conversion while preserving NaN and signed zero.
React Native Version
0.87.1 and current main
Affected Platforms
JavaScript runtime - All
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the shared numeric conversion used when constructing DOMRectReadOnly and in mutable DOMRect setters. Check how omitted or nullish values are defaulted, then verify that supplied NaN and negative zero retain their values while only the intended defaults become zero.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100