react / react/react-native

XMLHttpRequest corrupts headers named after Object prototype properties

Open
#58,232 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Author Feedback Needs: Repro
Dominant language
C++
Stars
127k
Forks
25.3k
Avg merge
1d 23h
Merged PRs (30d)
4

Description

Description

React Native XMLHttpRequest stores request headers and normalized response headers in ordinary objects. Valid header names that collide with Object.prototype are therefore corrupted or hidden: repeated Constructor values begin with inherited function text, __proto__ cannot be stored normally, and an absent toString response header is returned as an inherited function instead of null.

Expected behavior

All valid case-insensitive header names should be stored, combined, and retrieved as their own values without interacting with JavaScript object prototypes.

React Native Version

0.87.1 and current main

Affected Platforms

JavaScript networking - All

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at React Native's XMLHttpRequest implementation and inspect how request headers and normalized response headers are stored and retrieved. Find or add focused tests for Constructor, proto, and an absent toString header; done means valid case-insensitive names retain their own values without interacting with Object.prototype.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.