AppRegistry mishandles keys inherited from Object.prototype
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.3k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 4
Description
Description
The public AppRegistry stores app and section keys in plain object literals. Looking up an unregistered key such as constructor returns an inherited Object member. Registering the valid string key __proto__ mutates the registry prototype rather than creating an own entry, so the app/section key lists omit it.
The defect is present in React Native 0.87.1 and current main.
Steps to reproduce
Call AppRegistry.getRunnable("constructor"), then register an app or section named __proto__ and inspect getAppKeys() / getSectionKeys().
Expected behavior
Only explicitly registered keys should resolve, and all string app/section keys should be stored as ordinary own entries.
React Native Version
0.87.1 and current main.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the public AppRegistry entry points named in the report: getRunnable(), registerApp or section registration, and getAppKeys()/getSectionKeys(). Reproduce the constructor lookup and proto registration cases, then inspect how keys are stored and resolved. Done means unregistered inherited names do not resolve and every registered string key appears in the relevant key list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100