react / react/react-native

`@react-native/assets` ships Flow instead of JS

Open
#36,343 5 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Never gets stale
Dominant language
C++
Stars
127k
Forks
25.3k
Avg merge
1d 23h
Merged PRs (30d)
4

Description

Description

The assets package is shipping flow JS directly, making it break when importing on Next.js. It should build prior to publishing and remove types.

See: https://github.com/facebook/react-native/blob/main/packages/assets/registry.js

Let me know if I should PR, though I know TypeScript and not flow. Could also migrate it.

React Native Version

0.71

Output of npx react-native info

N/A

Steps to reproduce

See https://github.com/facebook/react-native/blob/main/packages/assets/registry.js

Snack, code example, screenshot, or link to a repository

If you need a repro, you can try importing @react-native/assets in Next.js. It's pretty self-explanatory though.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/assets/registry.js and reproduce importing @react-native/assets from Next.js. Trace the assets package's publishing and build configuration, then verify the published entry is compiled JavaScript without Flow types; done when the Next.js import succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, next.js, react-native
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.