[iOS/iPadOS] - `FlatList` refresh handling broken/dysfunctional
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.3k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 4
Description
Description
Description
Since upgrading to the new architecture it seems like the refresh/pull-to-refresh feature of the FlatList is broken/not fully functional any longer. However, this is only the case if you place another FlatList OR ScrollView in the same view. Placing just a list in each view does not lead to problems.
Pulling down and refreshing works twice before being dysfunctional. Eventually, after a certain pattern, the functionality works again twice and then breaks again.
The sample code provided below works as intended on the old architecture.
Version
0.71.3
Output of npx react-native info
Not relevant for this issue.
Steps to reproduce
- Create a new
react-nativeproject with the help of the CLI, install all dependencies and pods and build the application on a iOS/iPadOS device. - Paste the provided code into the
App.tsxfile - Pull down the list and notice how the loading spinner is displayed for a brief time
- Use the
Switchbutton to unmount the current view and mount another one containing twoFlatListcomponents and aScrollView(for demonstration purposes). - Pull to refresh on the most left
FlatList(orange one) and once again use theSwitchbutton - Pull down the initial list and notice how the loading spinner is NOT displayed and the
onRefreshhandler is not called
Snack, code example, screenshot, or link to a repository
https://github.com/coolersham/NRNA-flatlist-reload-bug
import React, { useState } from "react"
import {
FlatList,
ScrollView,
Text,
TouchableOpacity,
View,
} from "react-native"
export default function App(): JSX.Element {
return (
<View
style={{
flex: 1,
padding: 48,
alignItems: "center",
backgroundColor: "white",
}}
>
<ListDemo />
</View>
)
}
function ListDemo() {
const data = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
const [show, setShow] = useState(true)
const style = { backgroundColor: "orange" }
const switchButton = (
<TouchableOpacity
style={{
height: 48,
width: 300,
alignItems: "center",
backgroundColor: "red",
justifyContent: "center",
}}
onPress={() => setShow((show) => !show)}
>
<Text style={{ color: "white" }}>Switch</Text>
</TouchableOpacity>
)
if (show)
return (
<>
{switchButton}
<FlatList
data={data}
style={style}
refreshing={false}
renderItem={GenericListItem}
onRefresh={() => console.log("List #1 refresh is called")}
/>
</>
)
return (
<>
{switchButton}
<View
style={{
flex: 1,
flexDirection: "row",
}}
>
<FlatList
data={data}
style={style}
refreshing={false}
renderItem={GenericListItem}
onRefresh={() => console.log("List #2 refresh is called")}
/>
{/* Breaks refresh handling of both lists occasionally */}
<FlatList
data={data}
renderItem={GenericListItem}
style={{ backgroundColor: "purple" }}
/>
{/* The same applies to the normal ScrollView component */}
<ScrollView style={{ backgroundColor: "blue" }}>
{data.map((item) => (
<GenericListItem key={item} />
))}
</ScrollView>
</View>
</>
)
}
function GenericListItem() {
return (
<View style={{ width: 300, height: 48 }}>
<Text>Generic test item</Text>
</View>
)
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked reproduction project and its App.tsx, then reproduce the refresh sequence on an iOS/iPadOS device using the new architecture. The fix is complete when switching between views containing multiple FlatList or ScrollView components does not disable the initial list's spinner or onRefresh handler.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100