Components inside the Text wont follow the width of the Text when screen Orientation is changed
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.3k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 4
Description
Description
So I implement AdMobBanner and then decided to place is inside the Text component.
Why I did that, Well I have AdMobBanner inside TouchableOpacity component and if I do not place it inside the Text, the user wont be able to click on it.
Now this is not the problem, the problem is that when the screen Orientation is changed the component inside the Text wont follow for some reason.
React Native version:
System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i7-3820 CPU @ 3.60GHz
Memory: 1.13 GB / 7.92 GB
Binaries:
Node: 15.6.0 - C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm: 6.14.11 - D:\Projects\NovelManager\node_modules\.bin\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 26, 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 30.0.3
System Images: android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Not Found
Visual Studio: 16.7.30517.126 (Visual Studio Enterprise 2019)
Languages:
Java: 11.0.10 - C:\Program Files\AdoptOpenJDK\jdk-11.0.10.9-hotspot\bin\javac.EXE
Python: 3.9.1 - C:\Python39\python.EXE
npmPackages:
@react-native-community/cli: Not Found
react: ~16.13.1 => 16.13.1
react-native: ^0.63.4 => 0.63.4
react-native-windows: Not Found
npmGlobalPackages:
*react-native*: Not Found
Steps To Reproduce
I have create a demo that represent the problem here on snack
To test this you will have to view it on your phone.
This is the code you should look into when you navigate snack
<Text key={attr["index"]} style={{maxWidth:"100%",minWidth:"100%", backgroundColor:"red", justifyContent:"center"}} onPress={e=> {e.preventDefault() }}>
<Banner bannerSize="smartBannerPortrait"
/>
</Text>
Expected Results
The Text component should behave like View and when the screen Orientation is changed its children should also follow the Text component style
Snack, code example, screenshot, or link to a repository:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the linked Snack and reproduce the problem on a phone by changing orientation. Start with the Text component containing the Banner and compare its width with the expected behavior; done means the embedded Banner follows the Text width after orientation changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100