react / react/react-native

TextInput onChangeText is firing at wrong time when type with Chinese input keyboard in iOS

Open
#30,578 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

API: Keyboard Component: TextInput Needs: Triage :mag: Never gets stale Platform: iOS
Dominant language
C++
Stars
127k
Forks
25.3k
Avg merge
1d 23h
Merged PRs (30d)
4

Description

Description

TextInput onChangeText is firing at wrong time. Here is the gif to show the problem.
RPReplay_Final1607783480

I am typing the Chinese wording "你好" with a Chinese input keyboard in iOS.

  1. The char "你" is inputted by the code "人火".
  2. I type with the code "人火" and these two codes are highlighted in grey in the textbox. The input method is still not completed yet. The code "人火" should not be considered as a text change event. However, onChangeText is triggered.
    螢幕截圖 2020-12-12 下午11 10 33
  3. After I select the char "你" in Chinese input keyboard, onChangeText is triggered twice.
    螢幕截圖 2020-12-12 下午10 56 30

React Native version:

System:
    OS: macOS 11.0.1
    CPU: (8) x64 Intel(R) Core(TM) i7-8557U CPU @ 1.70GHz
    Memory: 751.11 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.1 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.14.8 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.6953283
    Xcode: 12.2/12B45b - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz => 0.63.2 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. Open https://snack.expo.io/@hkhermanho/textinput-with-chinese
  2. Type any Chinese characters with Chinese input method

Expected Results

onChangeText should not be fire before the input method is done. It should be fired 2 times for 2 Chinese characters instead of 8 times.
螢幕截圖 2020-12-12 下午11 02 07

Snack, code example, screenshot, or link to a repository:

https://snack.expo.io/@hkhermanho/textinput-with-chinese

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue from the linked Expo Snack on iOS with a Chinese input method. Trace how TextInput handles composition and when onChangeText fires during the described input sequence. Done means callbacks occur only after composition completes and fire twice for two Chinese characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, react-native
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.