react / react/metro

LogBox code frames for console.error/warn showing wrong code

Open
#1,298 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5.6k
Forks
696
Avg merge
8m
Merged PRs (30d)
7

Description

Description

It appears that in 0.73, code frames are broken, and point to the wrong line. This repos for me by creating an empty project with npx react-native@latest init project, and adding console.log to the top of App.tsx:

function App(): React.JSX.Element {
  const isDarkMode = useColorScheme() === 'dark';

  const backgroundStyle = {
    backgroundColor: isDarkMode ? Colors.darker : Colors.lighter,
  };
  
  // 🚩 new line
  console.error('HIT');
  return ( ... )
}
Expectation

The code frame should point to this line with console.error.

Actual

The code frame points to something inside of View:

Screenshot 2023-12-14 at 2 26 08 PM

Note: the 4th line in the stack trace is the correct line: App.tsx:65 is where the console.error is:
Screenshot 2023-12-14 at 2 31 35 PM

Steps to reproduce
  1. `npx react-native@latest init myproject.
  2. Update App.tsx with console.error.
  3. Obsever LogBox codeframe is incorrect.
React Native Version

0.73.0

Affected Platforms

Runtime - iOS

Output of npx react-native info
System:
  OS: macOS 14.0
  CPU: (8) arm64 Apple M2
  Memory: 75.41 MB / 24.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.4.0
    path: ~/.nvm/versions/node/v20.4.0/bin/node
  Yarn:
    version: 1.22.19
    path: ~/.nvm/versions/node/v20.4.0/bin/yarn
  npm:
    version: 9.7.2
    path: ~/.nvm/versions/node/v20.4.0/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.12.1
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 15.0/15A240d
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.0
    wanted: 0.73.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false
Stacktrace or Logs
ERROR  HIT 
    at App (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.seventhree:125259:54)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.seventhree:59687:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.seventhree:59687:43)
    at AppContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.seventhree:59529:36)
    at seventhree(RootComponent) (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.seventhree:111251:28)
Reproducer

https://github.com/react-native-community/reproducer-react-native

Screenshots and Videos

Above

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked reproducer and trace Metro's handling of the stack trace used for LogBox code frames, comparing the reported App.tsx line with the displayed View frame. Done means console.error and console.warn code frames point to their actual source lines on iOS.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.