react-navigation / react-navigation/react-navigation.github.io

New redux warning?

Open
#137 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
324
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

Hello!

We used react-navigation on a project a while ago, and integrated it with our Redux store as per the documentation. But I've just noticed you now have a warning telling people not to do this.

  1. Can you elaborate why it's bad? "You probably don't need to do this" is a bit ambiguous.
  2. Managing navigation through actions was our main reason for doing it; it meant one LOGIN_SUCCEEDED action would mutate both our app state and the navigation state to put the user in the right place. What's the recommended approach instead? Is it to navigate without the navigation prop?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Redux integration warning and the linked navigating-without-navigation-prop documentation. Review the issue's questions and existing wording, then clarify why the integration is discouraged and identify the recommended approach for navigation after an action; the documentation should answer both questions directly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, react-native, redux
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.