react-navigation / react-navigation/react-navigation.github.io

Deeplinking guide has incorrect android intent-filter

Open
#1,119 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
324
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/react-navigation/react-navigation.github.io/blob/bfc09a18884e06304f9e79176ef5e9f3d2c0cb8c/versioned_docs/version-6.x/deep-linking.md?plain=1#L164-L179

The data fields gets merged:

<data android:scheme="mychat" /> 
<data android:scheme="https" android:host="www.example.com" /> 
<data android:scheme="http" android:host="www.example.com" /> 

becomes:

<data android:scheme="mychat"
           android:scheme="https"
           android:scheme="http"
           android:host="www.example.com" /> 

And with that, only mychat://www.example.com will open the app.

Source https://stackoverflow.com/a/27321468/5555803

The solution is to use different intent-filters.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Update versioned_docs/version-6.x/deep-linking.md, focusing on the Android intent-filter example at lines 164-179. Read the linked documentation and verify the Android data-merging behavior described in the issue. Done means the guide shows separate intent-filters for the listed schemes and accurately explains the resulting deep-link behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
documentation, mobile-dev
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.