react-navigation / react-navigation/react-navigation.github.io

Type checking nested navigator is missing StackParamList definition and usage

Open Beginner friendly
#1,118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
324
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

In the Nesting Navigators guide, the example given does not work with the stack structure provided in the page (which is not nested to begin with). I believe the author is implying a different nested stack (since the example is using StackParamList instead of RootStackParamList), but the definition for the StackParamList is not provided, confusing the reader into thinking it's the same as the RootStackParamList.

The definition of StackParamList and its usage should provided to give context to the nested examples.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open versioned_docs/version-6.x/typescript.md and read the Nesting Navigators section alongside the stack structure shown on the page. Add the missing StackParamList definition and its usage so the nested example is consistent with the surrounding example and understandable without guessing.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, react-native, typescript
Domain
documentation, mobile-dev
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.