react-native-webrtc / react-native-webrtc/react-native-incall-manager
setKeepScreenOn() does not keep screen on for iOS 13.1
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 597
- Forks
- 201
- Avg merge
- 2h 42m
- Merged PRs (30d)
- 1
Description
setKeepScreenOn() does not keep screen on for iOS 13.1
First off, just wanted to say thank you for the awesome library!
I was testing with iOS 13.1 today to see if I could keep the iPhone screen from turning off when I enable speakerphone. Unfortunately, I tried setting the flag to enable=true, (InCallManager.setKeepScreenOn(true)) when I start with {media: 'audio'}, the screen turns off when a user gets close to the proximity sensor.
I noticed that the only method in the obj-c setKeepScreenOn is to enable or disable the idleTimerDisable. Would it be better to turn off the proximity sensor instead?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ios/RNInCallManager/RNInCallManager.m at setKeepScreenOn, linked around the idleTimerDisable implementation. Reproduce the audio-mode behavior on iOS 13.1 and determine whether proximity handling or idle-timer handling causes the screen to turn off. Done means setKeepScreenOn(true) keeps the screen on when the proximity sensor is triggered, without breaking the intended call behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c, react-native
- Domain
- audio-video-rtc, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100