react-native-webrtc / react-native-webrtc/react-native-incall-manager
upgrading to androidx with RN 0.60 errors Nullable, ActivityCompact, ContextCompact
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 597
- Forks
- 201
- Avg merge
- 2h 42m
- Merged PRs (30d)
- 1
Description
Hi, I was trying to upgrade my RN version to latest (0.60) with latest version this ships to androidx. I can see that this package owner didn't update this package to latest version so. you can simply do it by updating InCallManagerModule.java this file inside node_modules.
`
// import android.support.annotation.Nullable;
import androidx.annotation.Nullable;
// import android.support.v4.app.ActivityCompat;
import androidx.core.app.ActivityCompat;
// import android.support.v4.content.ContextCompat;
import androidx.core.content.ContextCompat;
`
This is it you'll have to clean the build and run again!@
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with InCallManagerModule.java, where the issue identifies the Android support imports that fail during the React Native 0.60 AndroidX upgrade. Check the corresponding AndroidX replacements, then clean the build and run the package again. Done means the package builds without the reported Nullable, ActivityCompat, and ContextCompat errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, react-native
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100