react-native-webrtc / react-native-webrtc/react-native-incall-manager

Can't build the library in android for buildToolsVersion = "28.0.3"

Open
#110 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
597
Forks
201
Avg merge
2h 42m
Merged PRs (30d)
1

Description

Hi and thanks for this great library
I want to build my RN app with the latest android API level (which is 28 right now) but when I try to build and run the project on my test device it fails because of this library is usig API level 23.0.1 and consequently there would be API level mismatch.
Is there any way to use this library with API levels higher than 23.0.1 at all?

My development environment info::
react-native-cli: 2.0.1
react-native: 0.59.5
JDK 1.8.0_151

xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:37: error: cannot find symbol
import android.support.v4.app.ActivityCompat;
^
symbol: class ActivityCompat
location: package android.support.v4.app
xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:38: error: cannot find symbol
import android.support.v4.content.ContextCompat;
^
symbol: class ContextCompat
location: package android.support.v4.content
xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:1433: error: cannot find symbol
if (ContextCompat.checkSelfPermission(reactContext, targetPermission) == PackageManager.PERMISSION_GRANTED) {
^
symbol: variable ContextCompat
location: class InCallManagerModule
xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:1508: error: cannot find symbol
ActivityCompat.requestPermissions(currentActivity, new String[] {targetPermission}, requestPermissionCode);
^
symbol: variable ActivityCompat
location: class InCallManagerModule

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Android build configuration and InCallManagerModule.java in android/src/main/java/com/zxcpoiu/incallmanager, focusing on the ActivityCompat and ContextCompat imports and the reported API 23.0.1 versus 28.0.3 setup. Reproduce the build with React Native 0.59.5 and buildToolsVersion 28.0.3; done means the library builds without the reported missing-symbol errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, react-native
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.