react-native-webrtc / react-native-webrtc/react-native-callkeep
Keeping Mute Action in sync with Device and Remove duplicate functions exported to React Native
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 511
- Avg merge
- 9h 12m
- Merged PRs (30d)
- 2
Description
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch react-native-callkeep@4.3.16 for the project I'm working on.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java b/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
index 025480a..a6b5236 100644
--- a/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
+++ b/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
@@ -189,7 +189,7 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
public void reportNewIncomingCall(String uuid, String number, String callerName, boolean hasVideo, String payload) {
Log.d(TAG, "[RNCallKeepModule] reportNewIncomingCall, uuid: " + uuid + ", number: " + number + ", callerName: " + callerName);
- this.displayIncomingCall(uuid, number, callerName, hasVideo);
+ this.displayIncomingCall(uuid, number, callerName, hasVideo, null);
// Send event to JS
WritableMap args = Arguments.createMap();
@@ -434,10 +434,6 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
this.hasListeners = false;
}
- @ReactMethod
- public void displayIncomingCall(String uuid, String number, String callerName) {
- this.displayIncomingCall(uuid, number, callerName, false, null);
- }
@ReactMethod
public void displayIncomingCall(String uuid, String number, String callerName, boolean hasVideo) {
@@ -483,11 +479,6 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
conn.onAnswer();
}
- @ReactMethod
- public void startCall(String uuid, String number, String callerName) {
- this.startCall(uuid, number, callerName, false, null);
- }
-
@ReactMethod
public void startCall(String uuid, String number, String callerName, boolean hasVideo) {
this.startCall(uuid, number, callerName, hasVideo, null);
@@ -795,7 +786,8 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
Log.w(TAG, "[RNCallKeepModule] setMutedCall ignored because no connection found, uuid: " + uuid);
return;
}
-
+ AudioManager audio = (AudioManager) reactContext.getSystemService(Context.AUDIO_SERVICE);
+ audio.setMicrophoneMute(shouldMute);
CallAudioState newAudioState = null;
//if the requester wants to mute, do that. otherwise unmute
if (shouldMute) {
This issue body was partially generated by patch-package.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java, reading reportNewIncomingCall, displayIncomingCall, startCall, and setMutedCall. Compare the issue's diff with the surrounding method declarations and verify that mute state reaches the device while only the intended React Native methods remain exported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, react-native
- Domain
- audio-video-rtc, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100