react-native-webrtc / react-native-webrtc/react-native-callkeep

Disable CallKit for China on iOS

Open
#805 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
511
Avg merge
9h 12m
Merged PRs (30d)
2

Description

Apple does not allow distribution to the App Store in China with CallKit features enabled.

There's a solution discussed here, using NSLocale to check the user's region and conditionally initialize Callkit: https://stackoverflow.com/questions/51016603/disabling-callkit-from-china-store-best-approach

The CallKeep equivalent I'm using:

  NSString *currentRegion = [[NSLocale currentLocale] objectForKey:NSLocaleCountryCode];
  if (![currentRegion isEqualToString:@"CN"]) {
    // Disable CallKit in China
    [RNVoipPushNotificationManager voipRegistration];
    [RNCallKeep setup:@{
      @"appName": @"Call App",
      @"maximumCallGroups": @1,
      @"maximumCallsPerCallGroup": @1,
      @"supportsVideo": @YES,
    }];
  }

However, Apple continues to reject my app, leading me to believe CallKeep continues to use CallKit features internally without setup.

How would I go by disabling CallKit completely? Could the locale check by any chance be implemented in CallKeep?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the iOS paths that invoke RNCallKeep setup and RNVoipPushNotificationManager voipRegistration, and review the linked CallKit locale discussion. Determine whether CallKit is initialized or used without setup, then define and verify behavior that disables all CallKit-related work for the China region.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c, react-native
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.