react-native-webrtc / react-native-webrtc/react-native-callkeep
canMakeMultipleCalls does not work for incoming calls
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 511
- Avg merge
- 9h 12m
- Merged PRs (30d)
- 2
Description
Bug report
-
I've checked the example to reproduce the issue.
The example app doesn't use this method -
Reproduced on:
-
Android
-
iOS
Description
canMakeMultipleCalls(false) is supposed to disable the add call button on the android call screen. This works for outgoing calls, but for the call screen on incoming calls, the button is still enabled.
Steps to Reproduce
- Call RNCallKeep.canMakeMultipleCalls(false)
- Start an outgoing call by calling RNCallKeep.startCall. Notice that the add call button is disabled.
- Create an incoming call by calling RNCallKeep.displayIncomingCall. Notice that the call button is not disabled.
Versions
- Callkeep: 4.3.4
- React Native: 0.68.2
- Android: 11
- Phone model: G91S
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Android handling of RNCallKeep.canMakeMultipleCalls(false), then compare the paths exercised by startCall and displayIncomingCall. Reproduce the issue in the example app on Android and verify that the add-call button is disabled for both outgoing and incoming calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100