react-native-webrtc / react-native-webrtc/react-native-callkeep

Crash

Open
#608 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
511
Avg merge
9h 12m
Merged PRs (30d)
2

Description

Bug report

  • [ Y ] I've checked the example to reproduce the issue.

  • Reproduced on:

  • [ Y ] Android

  • iOS

Description

Steps to Reproduce

Versions

- Callkeep: 4.3.3
- React Native: 0.67.2
- iOS:
- Android: 12
- Phone model: Realme 7 Pro

Logs

RNCallKeepModule.java line 983
io.wazo.callkeep.RNCallKeepModule.hasPhoneAccount

Fatal Exception: java.lang.SecurityException: Neither user 10394 nor current process has android.permission.READ_PHONE_NUMBERS.
       at android.os.Parcel.createExceptionOrNull(Parcel.java:2441)
       at android.os.Parcel.createException(Parcel.java:2425)
       at android.os.Parcel.readException(Parcel.java:2408)
       at android.os.Parcel.readException(Parcel.java:2350)
       at com.android.internal.telecom.ITelecomService$Stub$Proxy.getPhoneAccount(ITelecomService.java:1982)
       at android.telecom.TelecomManager.getPhoneAccount(TelecomManager.java:1391)
       at io.wazo.callkeep.RNCallKeepModule.hasPhoneAccount(RNCallKeepModule.java:983)
       at io.wazo.callkeep.RNCallKeepModule.endAllCalls(RNCallKeepModule.java:391)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
       at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188)
       at com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:233)
       at android.os.Looper.loop(Looper.java:344)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:226)
       at java.lang.Thread.run(Thread.java:920)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at RNCallKeepModule.java line 983 in hasPhoneAccount and trace the endAllCalls path shown in the Android 12 stack trace. Reproduce with the example on Android 12 and verify the completed change prevents the READ_PHONE_NUMBERS SecurityException during call cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, react-native
Domain
mobile, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.