react-native-webrtc / react-native-webrtc/react-native-callkeep

Maybe the didChangeAudioRoute listeners callback should get a name returned by getAudioRoutes

Open
#533 7 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
511
Avg merge
9h 12m
Merged PRs (30d)
2

Description

Bug report

  • I've checked the example to reproduce the issue.

  • Reproduced on:

  • Android

  • iOS

Description

Value returned by getAudioRoute() :

[ { name: 'iPhone Microphone', type: 'Phone' },
  { name: 'Speaker', type: 'Speaker' },
  { name: 'Venue', type: 'Bluetooth' },
  { name: 'HG00595', type: 'Bluetooth' } ]

Selecting an audio route on the call screen triggers the didChangeAudioRoute listener but the value what I get
in case selecting the Venue is { output: 'BluetoothHFP', reason: 3 }
in case selecting the HG00595 is { output: 'BluetoothHFP', reason: 3 }
in case selecting the iPhone is { output: 'Receiver', reason: 3 }
in case selecting the Speaker is { output: 'Speaker', reason: 4 }

The output string value shouldn't be the name of the selected audioRoute, just like how is returned by the getAudioRoute ?

image

Versions

- Callkeep: 4.3.2
- React Native: 0.64
- iOS: 15.2
- Android:
- Phone model: 6s Plus, 12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the getAudioRoute and didChangeAudioRoute entry points in the iOS implementation, comparing the route objects returned by the former with the callback payload described here. Done means selecting each listed route produces a callback whose output identifies that selected route.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, react-native
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.