react-native-webrtc / react-native-webrtc/react-native-callkeep
setup has both android and ios as required, it should be optional
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 511
- Avg merge
- 9h 12m
- Merged PRs (30d)
- 2
Description
Bug report
-
I've checked the example to reproduce the issue.
-
Reproduced on:
-
Android
-
iOS
Description
setup has both android and ios configs as required, it should be optional but if i am only building for one platform, i shouldnt have to pass settings for other platforms.
it would be helpful if i can only
Steps to Reproduce
in RNCallKeep.setup method pass only ios configuration
Versions
- Callkeep: 4.2.0
- React Native: 0.64
- iOS: 12.5
- Android:
- Phone model:
Logs
Paste here
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The entry point named is RNCallKeep.setup; start by tracing how its Android and iOS configuration arguments are validated when only iOS is passed. Reproduce the setup call from the issue, then verify that a single-platform configuration succeeds without requiring settings for the other platform.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, ios, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100