react-native-webrtc / react-native-webrtc/react-native-callkeep

[Android] Bug/Error when using selfManaged mode.

Open
#424 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
511
Avg merge
9h 12m
Merged PRs (30d)
2

Description

Bug report

I have encountered a bug, if selfManaged mode is set to true and use displayIncomingCall without number parameter, then a error occur with no information of error, except ssp.
On further debugging, I see that there is a function fromParts at line 189 in RNCallKeepModule.java, code:
Uri uri = Uri.fromParts(PhoneAccount.SCHEME_TEL, number, null);
Is it a bug or something necessary to use connectionservice?

  • I've checked the example to reproduce the issue.

  • Reproduced on:

  • Android

  • iOS

Steps to Reproduce

  1. Create new project, install react-native-callkeep.
  2. set selfManaged true, and use RNCallKeep.displayIncomingCall(uuid(),null,notification.data?.username,null,true);

Versions

- Callkeep: 4.2.0
- React Native: 0.63.4
- iOS:
- Android: 10
- Phone model: Moto One Macro 

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read RNCallKeepModule.java around line 189 and trace displayIncomingCall when selfManaged is true and number is omitted. Reproduce the provided call on Android and inspect the resulting error and ssp output; done means the expected handling of a missing number is established and verified with a regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, react-native
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.