react-native-webrtc / react-native-webrtc/react-native-callkeep
checkPhoneAccountPermission with microphone permission denied
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 511
- Avg merge
- 9h 12m
- Merged PRs (30d)
- 2
Description
Bug report
-
I've checked the example to reproduce the issue.
-
Reproduced on:
-
Android
-
iOS
Description
When the microphone permission is denied, calling setup does not show the phone account alert prompting the user to enable calling accounts.
Related to #177.
Steps to Reproduce
- Deny microphone permission.
- Call
setupfunction. - Nothing happens.
This is because checkPhoneAccountPermission returns false when any permissions are denied, thus preventing the alert being displayed.
Proposed Solution
Separating the permissions request and the phone account check would be useful to allow the app to request permissions and phone account at separate times.
Versions
- Callkeep: 4.1.0
- React Native: 0.64.0
- iOS:
- Android: 11
- Phone model: Pixel 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Android setup function and checkPhoneAccountPermission mentioned in the report. Reproduce the sequence with microphone permission denied, then verify that setup can request permissions and check the phone account separately so the phone account alert is displayed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100