react-native-webrtc / react-native-webrtc/react-native-callkeep
Problematic hint about didActivateAudioSession event
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 511
- Avg merge
- 9h 12m
- Merged PRs (30d)
- 2
Description
I had really hard time debugging issues regarding didActivateAudioSession event. I used it to play the ringback tune as it's suggested in the readme.md file. The problem is that in the case of unlocking the phone while an active video call the event is also fired. Since it tries to play a sound, for me it generates some native iOS errors that in the end crashes one of the streams in the active video call.
Thanks a lot for the all react-native webrtc related packages. You did good work! 👍
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the readme.md guidance for the didActivateAudioSession event and compare it with the reported behavior when unlocking an active video call. Update the guidance so the event's additional firing case and the ringback-audio risk are clear, then verify that the README no longer suggests an unsafe assumption.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, react-native
- Domain
- documentation, mobile
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100