react-native-webrtc / react-native-webrtc/react-native-callkeep

Caller Name is ignored in StartCall, updateDisplay, displayIncomingCall

Open
#187 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
511
Avg merge
9h 12m
Merged PRs (30d)
2

Description

Bug report

  • [] I've checked the example to reproduce the issue.

  • Reproduced on:

  • Android

  • iOS

Description

Hello. Thanks for this great package.
I am making a SIP app. I set everything up and everything works as expected, except the ability to show contactIdentifier and localizedCallerName in StartCall, updateDisplay, displayIncomingCall methods. I pass a parameter, but it seems to be ignored, the native phone dialer UI shows only the phone number (which I pass to handle parameter).
What am I doing wrong?
Many thanks in advance.

My phone is Xiaomi Mi 9T (also known as K20)
Android 9

Example:
my code is

...
const callerName = "some_test_caller_name"
RNCallKeep.startCall('example_uuid', number, callerName)
...

adb log shows, that CallKeep actually gets the "some_test_caller_name" string:
04-23 21:38:58.355 10194 10230 D RNCK:RNCallKeepModule: startCall number: 74996492223, callerName: some_test_caller_name 04-23 21:38:58.426 1576 3653 I Telecom : Event: RecordEntry TC@85: SET_CONNECTING, ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}, ***, UserHandle{0}: TSI.pC@ErY 04-23 21:38:58.651 1576 1576 I Telecom : CreateConnectionProcessor: Trying attempt CallAttemptRecord(ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}, ***, UserHandle{0},ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}, ***, UserHandle{0}): NOCBIR.oR@Erc 04-23 21:38:58.651 1576 1576 I Telecom : Logging.Events: Non-call EVENT: BIND_CS, ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}: NOCBIR.oR->CSFM.rF@Erc 04-23 21:38:58.655 1576 1576 I Telecom : ServiceBinderConnection: Service bound ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}: SBC.oSC@Erg 04-23 21:38:58.655 1576 1576 I Telecom : Logging.Events: Non-call EVENT: CS_BOUND, ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}: SBC.oSC@Erg 04-23 21:38:58.665 1576 3561 I Telecom : MiuiCallsManager: setCallState CONNECTING -> NEW, call: [TC@85, CONNECTING, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.crCo->H.CS.crCo->H.CS.crCo.pICR)->CSW.hCCC@E-E-Erg 04-23 21:38:58.669 1576 3561 I Telecom : VoiceReporter: onCallStateChanged(): [TC@85, NEW, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]] mHasRestartRinger: false: (...->CS.crCo->H.CS.crCo->H.CS.crCo.pICR)->CSW.hCCC@E-E-Erg 04-23 21:38:58.669 1576 3561 I Telecom : MiuiCallsManager: setCallState NEW -> DIALING, call: [TC@85, NEW, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.crCo->H.CS.crCo->H.CS.crCo.pICR)->CSW.hCCC@E-E-Erg 04-23 21:38:58.700 1576 3561 I Telecom : VoiceReporter: onCallStateChanged(): [TC@85, DIALING, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]] mHasRestartRinger: false: (...->CS.crCo->H.CS.crCo->H.CS.crCo.pICR)->CSW.hCCC@E-E-Erg 04-23 21:39:00.664 1576 3196 W ActivityManager: Unable to start service Intent { cmp=com.uis_softphone_rn/io.wazo.callkeep.RNCallKeepBackgroundMessagingService (has extras) } U=0: not found 04-23 21:39:01.656 1576 3196 I Telecom : InCallController: Sending updateCall [TC@85, DIALING, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: CSW.sCC@EsE 04-23 21:39:01.658 1576 3196 I Telecom : MiuiCallsManager: setCallState DIALING -> ACTIVE, call: [TC@85, DIALING, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: CSW.sA@EsI 04-23 21:39:01.662 1576 3196 I Telecom : VoiceReporter: onCallStateChanged(): [TC@85, ACTIVE, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]] mHasRestartRinger: false: CSW.sA@EsI 04-23 21:39:01.678 1576 3196 I Telecom : InCallController: Sending updateCall [TC@85, ACTIVE, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: CSW.sA@EsI 04-23 21:39:03.359 1576 3561 I Telecom : Call: Send disconnect to connection service for call: [TC@85, ACTIVE, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: ICA.dC(InCall package: com.android.incallui)@Eso 04-23 21:39:03.368 10194 10230 D RNCK:RNCallKeepModule: endCall called 04-23 21:39:03.375 1576 7353 I Telecom : InCallController: Sending updateCall [TC@85, ACTIVE, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.d->H.CS.d)->CSW.sDc@E-E-Eso 04-23 21:39:03.376 1576 7353 I Telecom : MiuiCallsManager: setCallState ACTIVE -> DISCONNECTED, call: [TC@85, ACTIVE, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.d->H.CS.d)->CSW.sDc@E-E-Eso 04-23 21:39:03.377 1576 7353 I Telecom : CallAudioManager: is ConfURI call disconnected = false call = [TC@85, DISCONNECTED, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.d->H.CS.d)->CSW.sDc@E-E-Eso 04-23 21:39:03.408 1576 7353 I Telecom : VoiceReporter: onCallStateChanged(): [TC@85, DISCONNECTED, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]] mHasRestartRinger: false: (...->CS.d->H.CS.d)->CSW.sDc@E-E-Eso 04-23 21:39:03.408 1576 7353 I Telecom : InCallController: Sending updateCall [TC@85, DISCONNECTED, com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService, tel:***********, A, childs(0), has_parent(false), [Capabilities: CAPABILITY_HOLD CAPABILITY_SUPPORT_HOLD CAPABILITY_MUTE], [Properties:]]: (...->CS.d->H.CS.d)->CSW.sDc@E-E-Eso 04-23 21:39:03.410 1576 7353 I Telecom : ConnectionServiceWrapper: Service unbound ComponentInfo{com.uis_softphone_rn/io.wazo.callkeep.VoiceConnectionService}, from unbind.: (...->CS.d->H.CS.d)->CSW.rC@E-E-Eso 04-23 21:39:03.578 10194 10230 D RNCK:RNCallKeepModule: endCall called 04-23 21:39:03.792 10194 10230 D RNCK:RNCallKeepModule: endCall called

Steps to Reproduce

Versions

- Callkeep:
- React Native:
- iOS:
- Android:
- Phone model: 

Logs

Paste here

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Android implementations of StartCall, updateDisplay, and displayIncomingCall, using the RNCallKeepModule log showing that callerName is received. Trace how contactIdentifier and localizedCallerName are passed into the native call UI. Done means the supplied caller name is shown instead of only the phone number on Android.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.