Inconsistent behavior on conditional render on mobile

Open
#740 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Start by reproducing the conditional state change around the Draggable component, comparing the original wrapper with the individually wrapped Baz 1 and Baz 2 examples. Determine whether the behavior comes from React conditional rendering or react-draggable, and document the conditions that reproduce the inconsistency; the issue names no repository files or tests.

Written by the indexing model from the issue text.

Description

If I have a component that looks like this:

const Foo = () => {
  const [state, setState] = useState(null);
  const renderBar = () => {
    if (state) { return (<div>Baz 1</div>); }
    return (<div>Baz 2</div>);
  }
  return (
    <Draggable>
      {renderBar()}
    </Draggable>
  );
}

Then there is a chance that when either Baz 1 or Baz 2 gets rendered, it's not draggable. I suspect that this has to do with the state changing and Draggable only applying to whichever gets the initial render.

This observation comes from about 2 hours of debugging... for context, in my project, state is actually passed into the Foo component and can be set outside of Foo. Baz 2 is a table of a lot of components, whose slow rendering may or may not have contributed to this inconsistent behavior.

I resolved the inconsistency by individually wrapping Baz1 and Baz2 like this:

const Foo = (props) => {
  const [state, setState] = useState(null);
  const renderBar = () => {
    if (state) { return (
      <Draggable>
        <div>Baz 1</div>
      </Draggable>
    ); }
    return (
      <Draggable>
        <div>Baz 2</div>
      </Draggable>
    );
  }
  return renderBar();
}

Is this inconsistency specific to react-draggable or is it an expected behavior of react?

Dominant language
JavaScript
Stars
9.3k
Forks
1k
Avg merge
3d 8h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react-grid-layout/react-draggable

All issues in react-grid-layout/react-draggable

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.