Dragging outside of container triggers text selection in Safari
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start by reviewing commit 9998c562dee9aa9ab8aa2e5816ea0530ffadd105 and reproduce the issue in Safari 14.1.2 with react-draggable 4.2.0 or 4.4.4. The work is done when dragging an element against its container boundary no longer selects text outside the element.
Written by the indexing model from the issue text.
Description
If you are dragging an element in Safari, the cursor turns into the text selection cursor. If the elements reaches its constraints aka. its containers border and the mouse drags and moves further, outside elements get selected.
It seems that the styles added to prevent the selection are not working in Safari => https://github.com/react-grid-layout/react-draggable/commit/9998c562dee9aa9ab8aa2e5816ea0530ffadd105
Adding user-select: none; to the body while the dragging happens prevents the selection from happening. Maybe this might be a solution for that problem? I could not find out why exactly the current implementation does not work in Safari, but I will report back once I found the issue.
Tested with:
- Safari 14.1.2 on macOS 11.5 (Big Sur)
- react-draggable 4.2.0 & 4.4.4 (currently latest version)
- Dominant language
- JavaScript
- Stars
- 9.3k
- Forks
- 1k
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react-grid-layout/react-draggable
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#784 · 4 comments · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
react-grid-layout/react-draggable#782 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
react-grid-layout/react-draggable#781 · 1 comment · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#780 · 8 comments ·
All issues in react-grid-layout/react-draggable
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
avniproject/avni-client#2135 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
babalae/bettergi-scripts-list#3674 ·
-
A-Release-Notes C-Editing D-Modest S-Ready-For-Implementation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
bevyengine/bevy-website#2595 ·
-
ecosystem wording
Difficulty 1/5 Under an hour Newbie friendliness 90/100
matrix-org/matrix.org#3649 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vadimdemedes/ink#1029 ·