onClick doesn't work when onDrag and onStop are present

Open
#419 6 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Start by reproducing the JSX example with Draggable, especially the interaction between onDrag, onStop, and the button's onClick handler. Check whether the click still toggles the map when onStop is supplied and whether the stop callback is invoked once rather than twice; the issue is resolved when both behaviors match those expectations.

Written by the indexing model from the issue text.

Description

Sorry about the rubbish title, couldn't think of a way to make it concise :P

Basically I have a draggable tab (which is used to display a full screen map), I can successfully drag the tab left and right (as desired) and I can click the tab to toggle it in and out of view.

However, when I add a function to the 'onStop' handler, the click functionality stops responding. It still registers clicks, but doesn't actually toggle the map (like it did correctly when I didn't have an onStop handler)

UPDATE: I've noticed that when I click the drag handle, it's also firing the onStop event TWICE (shouldn't this only happen onDragStop?)

I'll add my code below for reference (i'm omitting all the uneccesary stuff incase you wonder).

JSX:

<Draggable
          axis="x"
          handle=".handle"
          bounds={{ left: -this.state.windowWidth, right: 0 }}
          defaultPosition={{ x: 0, y: 0 }}
          position={this.state.controlledPosition}
          onDrag={this.toggleMapViaDrag}
          onStop={this.onMapDragStop}
        >
        <ViewMapMobileButton onClick={this.toggleMapViaClick} className="handle" />
</Draggable>

JS:

toggleMapViaDrag(e, position) {
    const { x } = position;
    this.setState(prevState => ({
      controlledPosition: { x, y: 0 },
      mapVisible: x < -prevState.windowWidth / 2,
    }));
  }

  toggleMapViaClick(e) {
    e.preventDefault();
    e.stopPropagation();
    const { y } = this.state.controlledPosition;

    this.setState(prevState => ({
      controlledPosition: prevState.mapVisible ? { x: 0, y } : { x: 0 - prevState.windowWidth, y },
      mapVisible: !prevState.mapVisible,
    }));
  }

onMapDragStop() {
    const { y } = this.state.controlledPosition;
    this.setState(prevState => ({
      mapVisible: prevState.controlledPosition.x > -prevState.windowWidth / 2,
      controlledPosition:
        prevState.controlledPosition.x <= -prevState.windowWidth / 2
          ? { x: 0 - prevState.windowWidth, y }
          : { x: 0, y },
    }));
  }
Dominant language
JavaScript
Stars
9.3k
Forks
1k
Avg merge
3d 8h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react-grid-layout/react-draggable

All issues in react-grid-layout/react-draggable

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.