onClick doesn't work when onDrag and onStop are present
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, react
- Domain
- frontend
Research direction
Start by reproducing the JSX example with Draggable, especially the interaction between onDrag, onStop, and the button's onClick handler. Check whether the click still toggles the map when onStop is supplied and whether the stop callback is invoked once rather than twice; the issue is resolved when both behaviors match those expectations.
Written by the indexing model from the issue text.
Description
Sorry about the rubbish title, couldn't think of a way to make it concise :P
Basically I have a draggable tab (which is used to display a full screen map), I can successfully drag the tab left and right (as desired) and I can click the tab to toggle it in and out of view.
However, when I add a function to the 'onStop' handler, the click functionality stops responding. It still registers clicks, but doesn't actually toggle the map (like it did correctly when I didn't have an onStop handler)
UPDATE: I've noticed that when I click the drag handle, it's also firing the onStop event TWICE (shouldn't this only happen onDragStop?)
I'll add my code below for reference (i'm omitting all the uneccesary stuff incase you wonder).
JSX:
<Draggable
axis="x"
handle=".handle"
bounds={{ left: -this.state.windowWidth, right: 0 }}
defaultPosition={{ x: 0, y: 0 }}
position={this.state.controlledPosition}
onDrag={this.toggleMapViaDrag}
onStop={this.onMapDragStop}
>
<ViewMapMobileButton onClick={this.toggleMapViaClick} className="handle" />
</Draggable>
JS:
toggleMapViaDrag(e, position) {
const { x } = position;
this.setState(prevState => ({
controlledPosition: { x, y: 0 },
mapVisible: x < -prevState.windowWidth / 2,
}));
}
toggleMapViaClick(e) {
e.preventDefault();
e.stopPropagation();
const { y } = this.state.controlledPosition;
this.setState(prevState => ({
controlledPosition: prevState.mapVisible ? { x: 0, y } : { x: 0 - prevState.windowWidth, y },
mapVisible: !prevState.mapVisible,
}));
}
onMapDragStop() {
const { y } = this.state.controlledPosition;
this.setState(prevState => ({
mapVisible: prevState.controlledPosition.x > -prevState.windowWidth / 2,
controlledPosition:
prevState.controlledPosition.x <= -prevState.windowWidth / 2
? { x: 0 - prevState.windowWidth, y }
: { x: 0, y },
}));
}
- Dominant language
- JavaScript
- Stars
- 9.3k
- Forks
- 1k
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react-grid-layout/react-draggable
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#784 · 4 comments · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
react-grid-layout/react-draggable#782 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
react-grid-layout/react-draggable#781 · 1 comment · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#780 · 8 comments ·
All issues in react-grid-layout/react-draggable
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100