Accept function as child or pass raw position
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, react
- Domain
- frontend
Research direction
No files, tests, or entry points are named. Begin by locating how react-draggable renders its child and passes position, style, and mouse/touch handlers; clarify whether the intended API is a function child, raw position data, or both, then add coverage for the chosen behavior.
Written by the indexing model from the issue text.
Description
It would be convenient if react-draggable accepted a function as a child. Instead of requiring the child be a <div /> or <svg /> and passing the appropriate props, a function would with called with the position. For example:
<Draggable>
{
/* additional arguments could be onTouchStart, onMouseMove, etc. */
(position, ...args) => {
<div
style={{
transform=`translateX(${position.x}px) translateY(${position.y}px)`
}}
{...args}
>
Drag me!
</div>
}
}
</Draggable>
This would allow greater flexibility in how the child component can be structured.
Otherwise it is easy enough to pass along onMouse/onTouch events and the style prop - but if the child component needs to consume the position for reasons other than style, it must regex the values out of the style.transform string. A compromise could be always pass the raw position object as well.
My apologies if this has been brought up in the past; I couldn't find any other mention.
- Dominant language
- JavaScript
- Stars
- 9.3k
- Forks
- 1k
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react-grid-layout/react-draggable
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#784 · 4 comments · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
react-grid-layout/react-draggable#782 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
react-grid-layout/react-draggable#781 · 1 comment · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
react-grid-layout/react-draggable#780 · 8 comments ·
All issues in react-grid-layout/react-draggable
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100