Does not respect bounds on new props

Open
#346 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Start by tracing where bounds are calculated during drag and how new bounds props are handled before dragging. Reproduce both reported cases: changed parent bounds and child scaling that places an element outside its draggable bounds. Done means updated bounds are respected immediately and scaled children remain recoverable.

Written by the indexing model from the issue text.

Description

Bounds seem to be calculated only on drag which presents a couple of issues:

  1. If bounds are changed and passed down from a parent component they will not be respected until the element is dragged

  2. Scaling operations on children can cause them to be outside of draggable element bounds and will not be recoverable since not able to click on the now invisible element

Dominant language
JavaScript
Stars
9.3k
Forks
1k
Avg merge
3d 8h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react-grid-layout/react-draggable

All issues in react-grid-layout/react-draggable

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.