react-component / react-component/virtual-list

Enhancement: reduce the inline style

Open
#174 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
814
Forks
171
Avg merge
1h 3m
Merged PRs (30d)
3

Description

Intro

I wanna change the background of thumb, but this style is an inline style so that I can't rewrite it.

https://github.com/react-component/virtual-list/blob/00915b476d8f7a47db851ecd78bce842ddb4f8dd/src/ScrollBar.tsx#L209-L227

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/ScrollBar.tsx lines 209-227, where the scrollbar thumb's inline styling is defined. Review which inline styles prevent changing the thumb background externally, then make the styling overridable and verify that the scrollbar still renders correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.