react-component / react-component/util

switchScrollingEffect.js 中的isBodyOverflowing方法,在下面一种场景中有点欠缺:

Open
#69 1 comment 0 reactions 1 assignee View on GitHub

@shaodahong is already working on this.

Since Jan 6, 2020.

Dominant language
TypeScript
Stars
670
Forks
205
Avg merge
11d 17h
Merged PRs (30d)
4

Description

switchScrollingEffect.js 中的isBodyOverflowing方法,在下面一种场景中有点欠缺:

  在全局的body的样式上增加了overflow-y:scroll,至于为什么要加,原因是想解决左侧菜单栏切换,右侧对应的内容有无溢出不会出现页面抖动的问题。
  例如:https://preview.pro.ant.design/dashboard/analysis
  从分析页面到异常页403,右侧内容就会因为滚动条的原因抖动。

  如果把这个样式设置到html 上,虽然没上述问题,但是在结合弹框Modal 使用时,就会出现弹框的遮罩层遮不住滚动条,也有点不合适。

  在上面这种场景下,isBodyOverflowing期望是被返回true 的。

Originally posted by @yangdongMC in https://github.com/react-component/util/pull/65#issuecomment-571016566

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.