react-component / react-component/util
Build issues when using rollup commonjs plugin
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 670
- Forks
- 205
- Avg merge
- 11d 17h
- Merged PRs (30d)
- 4
Description
The CommonJS plugin for Rollup doesn't seem to like destructured imports like:
import { isFragment } from 'react-is';
Using a named import or default import fixes this issue:
import * as ReactIs from 'react-is'; // or
import ReactIs from 'react-is';
When using tools like pika, we don't have direct control over the commonjs plugin so we can't configure named exports on react-is.
See relevant issues:
- pikapkg/builders#34
- mui-org/material-ui#18791
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the destructured react-is import with the Rollup CommonJS plugin and compare it with the named and default import examples in the issue. Investigate the relevant Rollup or build configuration; done means the destructured import builds successfully without requiring callers to configure named exports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, rollup, typescript
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100