react-component / react-component/trigger

rc-align and rc-animate deps could be bumped

Open
#74 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
391
Forks
245
PR merge metrics
No merged PRs in 30d

Description

Older versions of rc-animate and rc-align don't work in react 16, and when I install rc-trigger for some reason yarn selects those older versions for installation unless I add resolutions to override it.

The dependencies should be updated to require a version of those libraries that work in react 16 now that this library requires react 16.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect rc-trigger’s dependency declarations and the installed dependency tree first, focusing on rc-animate and rc-align. Update their requirements to React 16-compatible versions, then verify that installing rc-trigger no longer selects older versions and run the available tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.