react-component / react-component/trigger

Random error on unmount : Unable to find node on an unmounted component.

Open
#322 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
391
Forks
245
PR merge metrics
No merged PRs in 30d

Description

Actions

We have an antd slider mounted on a Lazy loaded page (with a Suspense parent).
When we click in the menu of our website, this unmount the current lazy loaded page and load an other lazy loaded page. (Using react router component Route)
During this operation, we sometime have an error popping on rc-trigger library.

Is there any way to protect against this ?

Error
Error: Unable to find node on an unmounted component.
  at a(webpack://lcdp-react/../node_modules/react-dom/cjs/react-dom.production.min.js:56:67)
  at Zb(webpack://lcdp-react/../node_modules/react-dom/cjs/react-dom.production.min.js:57:217)
  at exports.findDOMNode(webpack://lcdp-react/../node_modules/react-dom/cjs/react-dom.production.min.js:320:226)
  at getRootDomNode(webpack://lcdp-react/../node_modules/rc-trigger/lib/index.js:255:34)
  at attachParent(webpack://lcdp-react/../node_modules/rc-trigger/lib/index.js:349:29)
  at _this.attachId(webpack://lcdp-react/../node_modules/rc-trigger/lib/index.js:367:19)
  at callRef(webpack://lcdp-react/../node_modules/rc-trigger/node_modules/rc-util/lib/raf.js:35:7)
  at realId(webpack://lcdp-react/../node_modules/rc-trigger/node_modules/rc-util/lib/raf.js:39:9)
  at s(webpack://lcdp-react/../src/helpers.ts:98:1)
Context

rc-trigger version : 5.3.4
antd version : 4.17.3

Yours faithfully,
LCDP

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with rc-trigger/lib/index.js at getRootDomNode, attachParent, and attachId, then inspect the rc-util raf callbacks shown in the stack trace. Reproduce navigation from a Suspense-mounted page to another Route while an antd slider unmounts. Done means the unmount transition no longer produces this error, with coverage for the reported scenario if the repository has a suitable test entry point.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.