react-component / react-component/trigger
findDOMNode is deprecated in StrictMode.
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 391
- Forks
- 245
- PR merge metrics
- No merged PRs in 30d
Description
findDOMNode is deprecated in StrictMode but trigger still uses it.
react version: 16.9.0.
Using findDOMNode will cause below Warning:
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Wave which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
in button (created by Button)
in Wave (created by Button)
in Button (created by Trigger)
in Trigger (created by ForwardRef(Tooltip))
in ForwardRef(Tooltip) (created by Tooltip)
in Tooltip (created by Popover)
...
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Trigger, Tooltip, Button, and Wave path shown in the warning to locate where findDOMNode is used. Reproduce the warning with React 16.9.0 and StrictMode, then verify the warning is gone while the trigger behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100