react-component / react-component/trigger

destroyPopupOnHide doesn't remove container

Open
#106 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
391
Forks
245
PR merge metrics
No merged PRs in 30d

Description

I have a website where I am using Ant Design a lot and there are a few pages where so many popups and tooltips are used. Some of them are static text, some are dynamic. So I am using destroyTooltipOnHide and similar methods. But It seems that even after using destroyTooltipOnHide doesn't remove the entire content. Because rc-trigger is creating containers on every item and they are not destroyed at all. So it's leaving a lot of these

<div style="position: absolute; top: 0px; left: 0px; width: 100%;"><div></div></div>

even after destroyPopupOnHide. There should be a way to pass either the container manually or it should destroy these containers as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with rc-trigger and destroyPopupOnHide, then inspect the popup container lifecycle. Verify whether containers created for hidden popups remain in the document. Done means the generated containers are removed or a supported manual container option is provided, with the behavior covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.