react-component / react-component/tree
Syntax error triggered by onWindowDragEnd defined in Tree.tsx
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 490
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 5
Description
Within functionality onWindowDragEnd, it passes null into onNodeDragEnd.
calling node.props here will result in an error. As in this case, node is null.
@zombieJ Can any of the owners take a look? Any chance you guys can contrive a new package for release?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Tree.tsx at onWindowDragEnd around line 701 and follow its call to onNodeDragEnd around line 706. Reproduce the window-drag-end path where node is null, then verify that handling this case no longer reaches node.props and does not produce the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100