react-component / react-component/tree
drag handle rendered even when node is not draggable
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 490
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 5
Description
Hello
I see that in TreeNode component, the renderDragHandler is not checking if the node isDraggable or not and still showing the handle. I believe it should check if node is draggable and only then render the drag handle.
Can someone please confirm if this is an issue and/or if there is a workaround to not show the drag handle?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the TreeNode component at renderDragHandler and trace how isDraggable is provided to the node. Confirm the behavior for draggable and non-draggable nodes, then ensure the drag handle is absent when isDraggable is false and present when it is true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100