react-component / react-component/tree

ScrollTo on visible nodes

Open
#454 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
490
Avg merge
3d 17h
Merged PRs (30d)
5

Description

Hi team!

When invoking tree.scrollTo({ key: "some key" }), the tree always scrolls without considering if the element is already visible.
This leads to a change of scroll everytime.

Do you have any way of checking if the node is visible on the tree?

Thanks in advance,
Tiago Braga

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the tree.scrollTo({ key: "some key" }) entry point and trace how it decides to scroll. Reproduce the behavior with a node that is already visible, then verify that repeated calls no longer change the scroll position while off-screen nodes still scroll into view.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.