react-component / react-component/tree

Drag&Drop not working properly with external draggables

Open
#376 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
490
Avg merge
3d 17h
Merged PRs (30d)
5

Description

Dragging external draggables(non rc-tree nodes) onto last dragged tree nodes will not trigger related events.

Caused by:
https://github.com/react-component/tree/blob/08a591110cc48ea0b15b46b9ea92932409cab01c/src/Tree.tsx#L502-L505

I think dragNodesKeys state should be cleared when dragging ends.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/Tree.tsx around lines 502-505, where dragNodesKeys is retained after a drag. Reproduce dragging an external draggable onto the last dragged tree node, then verify that the related events fire after the drag ends and the stale drag state is cleared.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.