react-component / react-component/tree

switcherIcon overlay on default icon but not replace

Open
#311 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
490
Avg merge
3d 17h
Merged PRs (30d)
5

Description

I found that the switcherIcon seems just overlay on the default + icon.
For example, if i set background of switcherIcon to transparent in custom-switch-icon example, i will see the plus icon under the custom icon

Screenshot 2020-04-11 at 4 45 35 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the custom-switch-icon example and trace how switcherIcon is rendered, reproducing the issue with a transparent icon background. Done means the default plus icon is not visible beneath a custom switcherIcon; add or update coverage if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.