react-component / react-component/tree
Why distinguish dragOverGapTop and dragOverGapBottom?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 490
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 5
Description
I mean not only boolean values, but the whole UI. Why when I move items near other, there's different indicator if it's closer to top item, or bottom item? Why it's not just "in-between"?
I mean, look at [] in js. Does it have such complexities? You just have index. The dropPosition should be just an index.
AND it's not just naming, - by some reason dropPosition is changed depending on this dragOverGapTop/dragOverGapBottom values which I find very confusing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the drag-and-drop implementation that uses dragOverGapTop, dragOverGapBottom, and dropPosition, then inspect how the UI indicators and resulting insertion index relate. Done would require a maintainer-approved decision on whether the position model should change, plus agreed behavior and tests; the issue names no files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100