react-component / react-component/tree-select

undocumented breaking change - ref methods focus & blur missing

Open
#409 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
312
Forks
204
Avg merge
37m
Merged PRs (30d)
1

Description

i upgraded from 4.3.0 to 4.8.0. as you can see in the diff, the focus and blur methods are no longer exposed, so i'm getting errors when trying to use it like:

import ReactTreeSelect from "rc-tree-select";

const ref = createRef<ReactTreeSelect>();
...
selectViewsRef.current.focus()

this is a breaking change in a minor version upgrade. please follow semver and do not introduce breaking changes in non-major upgrades. also, as far as i can tell, this change is not documented anywhere in the changelog / release notes. please document it.

for now i'll be pinning 4.3.0 and looking for an alternative library.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked package diff between rc-tree-select 4.3.0 and 4.8.0, then inspect the repository's changelog or release notes. Confirm how the ref focus and blur methods changed, and document that breaking change and the affected versions in the project's established release-note format.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.