react-component / react-component/tour

为什么源码里maskRectSize要判断是否是isSafari?全部用百分比不行吗

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44
Forks
39
PR merge metrics
No merged PRs in 30d

Description

const maskRectSize = isSafari
? { width: '100%', height: '100%' }
: { width: '100vw', height: '100vh' };这段代码只是为了显示占比吗?屏幕放大缩小会导致遮罩异常?是否是有意设计或者是别的原因?如果不是,我可以提个pr吗

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the source for maskRectSize and isSafari, then inspect the surrounding mask sizing and target-tracking logic. Reproduce the tour mask in Safari and another browser at different viewport sizes or zoom levels; done requires a confirmed explanation of the conditional and a maintainer-approved change or documentation decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.