react-component / react-component/tour
A mask and a content separated in the DOM when getPopupContainer provided
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
Description
Duplicated this issue here, since it is more related to this package.
If I understand it correctly, this Mask component must be under the Portal. As it is done in the Dialog component
FYI @zombieJ
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/Tour.tsx around line 194 and compare its mask handling with the DialogWrap.tsx pattern around line 42. Reproduce the issue with getPopupContainer provided, inspect the DOM relationship between the mask and content, and verify that both are placed under the expected Portal structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100