react-component / react-component/tooltip

Dom nodes left duplicated after destroyTooltipOnHide

Open
#78 7 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
TypeScript
Stars
944
Forks
199
Avg merge
19h 1m
Merged PRs (30d)
3

Description

Is it normal that the library leave some node attached to the body even if destroyTooltipOnHide is activated.
Here is a simple preview of what it looks like, the nodes' children (actually containing tooltip content) are well destroyed but the nodes themselves are left in the tree.

capture d ecran 2017-05-10 a 18 33 58

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with destroyTooltipOnHide enabled and inspect the tooltip nodes attached to document.body after hiding and destroying the tooltip. Trace the cleanup path for the tooltip container; done means the tooltip content and its now-unused container nodes are removed from the DOM.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.