react-component / react-component/tabs

Tabs should allow user to pass `getPopupContainer` to the "moreTabs" Dropdown

Open
#318 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
572
Forks
241
Avg merge
4d 18h
Merged PRs (30d)
4

Description

rc-tabs renders the overflowing tabs in a dropdown's overlay. The overlay is always rendered at the <body> level and we cannot change that at the moment.

This make it impossible to scope the styling of the overlay, in particular with ant-design.

Adding a prop to <Tabs /> that allows to feed a different getPopupContainer prop to the dropdown displaying the overflowing tabs would solve this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Tabs component props and the overflow-tabs dropdown entry point. Trace how the dropdown is rendered and how its popup options are passed through. Done means a Tabs-level getPopupContainer option controls the overflow dropdown overlay without changing existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.