react-component / react-component/tabs

Issue with storyshots

Open
#161 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
572
Forks
241
Avg merge
4d 18h
Merged PRs (30d)
4

Description

When I use this component in a storyshot I get the following error:

TypeError: Cannot read property 'scrollHeight' of undefined
  at ScrollableTabBarNode.getScrollWH

Seems like it is relying on some browser property

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the storyshot failure, then inspect ScrollableTabBarNode.getScrollWH and the scrollHeight access mentioned in the stack trace. Determine which browser property is unavailable in the storyshot environment; done means the storyshot runs without the TypeError while preserving normal tab behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.