react-component / react-component/table
expandedRowRender is called 2 times instead 1 when row is expanded in versions >= 7
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 618
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 2
Description
I noticed that after upgrade from ant.design 3.x to 4.x
I've got flickering effects after expanding row.
The cause was multiple calls to expandedRowRender.
I tracked this new behavior to versions starting with 7 of this project.
I managed to write tests for it
working for version 6.x
https://github.com/KonradKuznicki/table/commit/93ccc85fa9aae66dccadff83071cff737868b20c
and failing for version 7.x
https://github.com/KonradKuznicki/table/commit/d40d6e05d690dfa38c91ac021ac862153a45ed4c
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the version 6.x and 7.x changes in the two linked commits, then inspect the tests added for expandedRowRender invocation counts. Reproduce the expansion case and confirm that expandedRowRender is called once, with the regression test passing for the affected versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100