react-component / react-component/table
请问下这个handleWheel的逻辑是不是可以加一个判断,没有fixedColumn的table并不需要这么处理?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 618
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 2
Description
https://github.com/react-component/table/blob/6.7.0/src/Table.js#L345
看了下代码,初步感觉这个handleWheel是为了处理ie11下fixedColumnsBodyLeft/Right的,那么,没有fixedColumnsBodyLeft和Right时,是不是可以不需要执行这个逻辑了。
目前这个逻辑引起了一个bug:https://github.com/ant-design/ant-design/issues/22341
谢谢。
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/Table.js around line 345 and inspect handleWheel's fixedColumnsBodyLeft/Right handling. Use the linked Ant Design issue to understand the regression; done means tables without fixed columns skip this handling while fixed-column tables retain it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100